feat: bridge useq plate_row/plate_col and use useq grid position names#124
Closed
ieivanov wants to merge 3 commits into
Closed
feat: bridge useq plate_row/plate_col and use useq grid position names#124ieivanov wants to merge 3 commits into
ieivanov wants to merge 3 commits into
Conversation
Propagate useq.Position.plate_row/plate_col to ome_writers Position.plate_row/plate_column in _build_stage_positions_plan. Build a Plate from position annotations when no WellPlatePlan is present. Use fov-style naming for grid points within plate wells to avoid duplicate output keys in acquire-zarr. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
8 tasks
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (80.64%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 97.69% 97.48% -0.22%
==========================================
Files 21 21
Lines 2516 2543 +27
==========================================
+ Hits 2458 2479 +21
- Misses 58 64 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Stop renaming positions to fov{idx}. Instead use the grid point's
name from useq (set by name_pattern on the grid plan). This moves
all position naming responsibility to useq-schema.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add _plate_row_to_str and _plate_col_to_str helpers to handle both int (0-based index) and str (direct name) plate coordinates from useq positions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
ome_writersto consume the newplate_row/plate_colfields from useq positions and delegate all position naming to useq-schema.Bridge useq
plate_row/plate_colto ome-writers positionsuseq.Position.plate_row/plate_col→ome_writers.Position.plate_row/plate_columnin_build_stage_positions_planand_pos_with_grid_point.int(0-based index → letter/number) andstr(pass-through) via new_plate_row_to_str/_plate_col_to_strhelpers.Plateobject from positionplate_row/plate_colannotations in_plate_from_useqwhen noWellPlatePlanis present.Use useq grid position names (stop overriding)
_build_well_plate_positions: useswell_pos.name(from useq'sname_pattern) instead of inventingfov{idx}._pos_with_grid_point: usesgp.nameinstead of overriding tofov{gp_idx}for plate positions.name_patternfield on grid plans.Full pipeline
Example
Produces zarr paths:
A/1/0000,A/1/0001, ...,B/2/0000,B/2/0001, ...Depends on: pymmcore-plus/useq-schema#268
Test plan
well_plate_with_pointstest expectations (fov0 → 0000)test_well_plate_fov_folder_nameszarr path expectations🤖 Generated with Claude Code